Update library heuristics as short term solution for missing metadata. #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return first `org-dartlang` library as `vmservice.rootLib` (or `main` if not found) - Manually add dart_sdk module metadata in `MetadataProvider`. - Update and add tests. Helps: dart-lang/sdk#44760 Helps: dart-lang#1226
grouma
approved these changes
Mar 29, 2021
| return lib.name.contains('org-dartlang'); | ||
| }); | ||
| return _rootLib ??= _rootLib = libraries.firstWhere((lib) { | ||
| return lib.name.contains('main'); |
There was a problem hiding this comment.
This can fail if not found. Should we default to the last lib in that case?
There was a problem hiding this comment.
The last lib is just random, whatever was read last from the metadata. Maybe we should just throw?
There was a problem hiding this comment.
will set it to the last one for now, since throwing here would make initialize fail.
added 2 commits
March 29, 2021 18:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org-dartlanglibrary asvmservice.rootLib(or
mainif not found)MetadataProvider.Helps: dart-lang/sdk#44760
Helps: #1226